feat(gh-ost): task blocked by implementation #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-bytebase
reviewed
Apr 14, 2022
|
PTAL |
d-bytebase
previously approved these changes
Apr 14, 2022
d-bytebase
reviewed
Apr 14, 2022
|
PTAL |
d-bytebase
approved these changes
Apr 14, 2022
|
@LiuJi-Jim FYI |
Please update the comment |
tianzhou
reviewed
Apr 14, 2022
| return nil, err | ||
| } | ||
| for _, taskDAG := range taskDAGList { | ||
| blockedBy = append(blockedBy, strconv.Itoa(taskDAG.ToTaskID)) |
There was a problem hiding this comment.
Is this reversed?
From -> To
Thus, it's the toTask blocked by the fromTask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1051, the type of
BlockedByis[]int, which is enough but is unfortunately not supported by jsonapi (google/jsonapi#209). So in this PR, I change the type to[]stringto workaround.