Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @unstable WIT features #110

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

benbrandt
Copy link
Contributor

@benbrandt benbrandt commented Oct 17, 2024

Provides the ability to pass in arguments for enabling @unstable features in a given WIT world.

If passed in, then the correct bindings will be generated, as well as when building the component.

For this to work, the features must be passed into both calls, but that seems reasonable.

The API for the flags was copied straight from the wit-bindgen cli, so it should be identical.

Addresses #109

@benbrandt
Copy link
Contributor Author

@dicej just pinging again in case you missed it. Let me know if there are any changes you'd like to see. If you are just busy, no rush. Thanks!

Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dicej dicej merged commit 72348e0 into bytecodealliance:main Oct 21, 2024
1 check passed
@dicej
Copy link
Collaborator

dicej commented Oct 21, 2024

BTW, I'll do a new 0.15.0 release with this and the other recent changes when I get a chance.

@benbrandt benbrandt deleted the unstable-features branch October 21, 2024 19:45
@benbrandt
Copy link
Contributor Author

Perfect thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants