-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioning support and update CMake configuration #3933
base: main
Are you sure you want to change the base?
Conversation
47f18d0
to
c38af70
Compare
@jirutka Please inform me if platforms other than Linux require the SONAME feature. |
The same applies to all Unix and Unix-like systems, so also BSDs and macOS. |
maybe you can do it for all platforms and let cmake do whatever appropriate? |
build-tested for macOS. master:
with this PR:
iirc, on macOS, a dylib can be loaded if
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable to me
core/version.h
Outdated
* version.h.in is a template file. version.h is a generated file. | ||
* Please do not edit both files directly. | ||
* | ||
* Any changes to the version should be done in the version.cmake file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you document the procedure?
eg. 1. update version.cmake, 2. run something (what?) to regen this file, 3. commit this generated file as well.
bd64d74
to
db69420
Compare
@yamt @loganek @TianlongLiang @xujuntwt95329 @wenyongh @no1wudi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
# Release Process | ||
|
||
WAMR has been deployed across various devices. A frequent release cycle would strain customers' testing resources and add extra deployment work. Two factors can trigger a new WAMR release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frequent release cycle would strain customers' testing resources
Not sure if I agree with that; customers can still choose to stick to a particular version or keep moving to the latest one. In fact, for some of the usecases it more frequent releases are better as it helps narrowing down any potential regressions which can only be seen when running WAMR at scale.
and add extra deployment work
Agree with that, we should probably discuss automating the process within TSC as much as we can to streamline the releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you proposing that we should streamline the release process (reduce manual work compared to the current method) and issue releases on a regular schedule, such as monthly?
core/version.h
Outdated
@@ -3,9 +3,20 @@ | |||
* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given we have .in
file now, does this file still have to be checked-in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for reminding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@no1wudi We are considering generating the version.h file from version.h.in during the CMake configuration process and removing version.h from the source code tree. The Nuttx CI is failing because it uses make instead of CMake and cannot create the version.h file. Is there a method to still generate version.h using make?
db69420
to
7bcdcf5
Compare
No description provided.