Add tests for sauron plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sip-21
commented
Oct 4, 2024
•
sip-21
commented
- Added tests for Sauron plugin using:
- Esplora API
- MutinyNet API (mempool.space)
- Tor proxy configuration
sip-21
force-pushed
the
add-sauron-tests
branch
2 times, most recently
from
2492513 to
32f2553
Compare
|
Tests are probably not yet complete, but provide a base. |
ca-ruz
force-pushed
the
sauron-mutinynet
branch
from
bef972b to
7402d7d
Compare
sip-21
force-pushed
the
add-sauron-tests
branch
from
2bc4c7f to
a3422cd
Compare
chrisguida
reviewed
Oct 4, 2024
sauron/sauron.py
Outdated
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| plugin = Plugin(dynamic=False) | |||
| plugin.sauron_socks_proxies = None | |||
| plugin.sauron_network = "test" | |||
| plugin.sauron_network = "bitcoin" | |||
There was a problem hiding this comment.
Why this change?
Seems like not a great idea to make mainnet the default?
There was a problem hiding this comment.
Upss, this was unintentional. A leftover from testing.
Fixed.
|
Great! All tests for Blockstream Esplora passed. I also ran them locally and they also passed. Would be great if you can write some tests for Mutinynet. |
sip-21
force-pushed
the
add-sauron-tests
branch
3 times, most recently
from
5ba626d to
dc2e886
Compare
sip-21
force-pushed
the
add-sauron-tests
branch
from
dc2e886 to
98f5fae
Compare
|
I ran |
|
@ca-ruz let's merge this and figure out the tests on the upstream PR |
|
Awesome @sip-21 Thanks for writing the tests for Sauron! Very thorough. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.