Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs dark mode v1.0 #4510

Merged
merged 24 commits into from
Jan 24, 2025
Merged

Docs dark mode v1.0 #4510

merged 24 commits into from
Jan 24, 2025

Conversation

akeller
Copy link
Member

@akeller akeller commented Oct 24, 2024

Description

Add a "dark mode" option to the docs web site, and check/refine CSS styles and content for any issues and to align branding with product dark mode.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@akeller akeller added the deploy Stand up a temporary docs site with this PR label Oct 24, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs October 24, 2024 20:43 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs October 24, 2024 21:21 Destroyed
@akeller akeller added the hold This issue is parked, do not merge. label Oct 24, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs October 24, 2024 21:59 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 14, 2024 12:05 Destroyed
@mesellings
Copy link
Contributor

Did some work on this today, still to check:

  • Admonitions
  • Tabs
  • API ref styles
  • Some images as discussed (transparent SVGs)

But other than that, it's already looking good (homepage and page content)! Shouldn't take much to finish off and get into review for the team.

@akeller FYI, I think this will be done before the hackathon, so might scrap that idea.

@github-actions github-actions bot temporarily deployed to camunda-docs November 14, 2024 17:22 Destroyed
@mesellings
Copy link
Contributor

SVGs non-blocking:
Investigated page: http://localhost:3000/docs/next/components/modeler/bpmn/bpmn-coverage

  • All images render sufficiently, though black outlined ones could be clearer.
  • Don't want to add a blanket background colour to .SVGs
  • Suggest follow-up work on this page to go through these images and improve for dark mode.

@mesellings mesellings changed the title dark mode? Docs dark mode Nov 15, 2024
@mesellings mesellings marked this pull request as ready for review November 15, 2024 12:01
@mesellings mesellings added kind/enhancement Issues related with enhancing existing documentation or the documentation structure (nice to have) component:docs Documentation improvements, including new or updated content labels Nov 15, 2024
@mesellings mesellings requested a review from a team November 15, 2024 12:01
@mesellings
Copy link
Contributor

mesellings commented Nov 15, 2024

@camunda/tech-writers The first iteration of dark mode is now ready for review in this PR:

https://preview.docs.camunda.cloud/pr-4510/index.html

Changes made as follows:

  • General dark mode styling/colours follows the product dark mode where possible.
  • Home page edited to suit dark mode.
  • Enable/disable using the icon at the top right of the banner.

Things to look at and check if we need to make further mods, or if they are 'okay as is' for now.

  • Admonition colours
  • Tabs (I changed them to 'buttons in dark mode)
  • Link colour (blue works better than orange in dark mode and matches product)
  • API ref styles
  • Images (might do some follow-up work on a few specific pages with transparent SVGs, but they are usable for now)

@mesellings mesellings changed the title Docs dark mode Docs dark mode v1.0 Nov 15, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs November 15, 2024 12:19 Destroyed
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool, thank you for all the time you've put into making this feasible!! 🙌

  • The admonitions, like you mentioned, including things like <details>, look very bright for the theme. When stacked with other elements (code blocks or admonitions nested in <details>) I think this becomes more apparent.
Screenshot 2024-11-15 at 8 29 29 AM
  • The badge buttons also look very bright:
Screenshot 2024-11-15 at 8 31 38 AM
  • The Algolia search seems to use a different default dark mode, but I don't think this necessarily needs to be updated in a V1 push.

I'm not sure how important any of these are! Nothing looks dramatic, everything seems to be functioning on the pages I'm reviewing in the areas you've asked us to take a look at. I'm stoked for this to be possible!

@github-actions github-actions bot temporarily deployed to camunda-docs November 19, 2024 20:49 Destroyed
mesellings
mesellings previously approved these changes Jan 17, 2025
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving my own work, but would benefit from other eyes 👀

Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking great! The areas familiar to me/that I know were less table like the APIs, etc, all seem to be functioning well for me.

My lingering question is on dark mode maintenance moving forward - I know we don't update the css or make new components too terribly often, but when we do, how can we be certain that dark mode is included in the review? I happen to be reviewing this and the Connectors PR simultaneously, and the new (and very cool!!) table there prompted me - if folks make similar PRs in the future, we should make sure dark mode doesn't get forgotten in the testing/reviewing process.

Otherwise, this is good to go from me! Thank you for all the work you've done pulling this off!

Copy link
Member Author

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot this was originally my PR until I went to review it. 🤣

I checked around on a few formatting and image-heavy pages (concepts, best practices, API reference docs) and didn't see anything I would call a bug or experience issue, so I have very limited feedback on those aspects.

‼️ I do have questions around branding, but mostly because I haven't looked closely at the brand colors and combinations. So the blue text on a black background, can we do that extensively? I'm not sure, but maybe you (@mesellings) already connected with the brand team or their assets to make an informed decision about this. I always want to stay on the good side of the brand police, so I would view this as a blocker.

The main page is super dark, so the contrast between the top nav and the footer is almost negligible on my monitor. It makes things challenging to see (Ask AI widget is black on black, as is the version drop down). This is probably ok for a first increment, but for a11y we'll likely need to refine this a bit.

Nit picks:

  • The main page boxes "hop" when I toggle light & dark
  • The BPMN coverage page is difficult to look at with green on white (but this has nothing to do with dark mode, it's like this in both modes)

@mesellings
Copy link
Contributor

mesellings commented Jan 20, 2025

Thanks for the great review @akeller 🚀 Issues addressed as follows:

‼️ I do have questions around branding, but mostly because I haven't looked closely at the brand colors and combinations. So the blue text on a black background, can we do that extensively? I'm not sure, but maybe you (@mesellings) already connected with the brand team or their assets to make an informed decision about this. I always want to stay on the good side of the brand police, so I would view this as a blocker.

The blue text colour is the same pattern used in the product for dark mode, so I think this is the way to go, is more accessible-safe, and aligns with brand guidelines 👍

The main page is super dark, so the contrast between the top nav and the footer is almost negligible on my monitor. It makes things challenging to see (Ask AI widget is black on black, as is the version drop down). This is probably ok for a first increment, but for a11y we'll likely need to refine this a bit.

Agreed - I've re-aligned with the product dark mode, so we use the same colours (I'm sure this changed since I did it) so less dark, footer and navbar have a bottom-border (as per the product), and I've added a border for the Kapa widget so it stands out more. Great comments, improves the dark mode definitely!

  • The main page boxes "hop" when I toggle light & dark

This is by design - in dark mode there is too much space here once the colour separation is removed, so I take out some padding otherwise the elements get orphaned.

  • The BPMN coverage page is difficult to look at with green on white (but this has nothing to do with dark mode, it's like this in both modes)

Something to look at in general on that page, I think we can probably do something better with the page elements, regardless of dark mode?

Thanks for these suggestions etc, the changes make the dark mode much better I think - valuable feedback! 👍 🚀

@github-actions github-actions bot temporarily deployed to camunda-docs January 20, 2025 12:01 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs January 21, 2025 08:47 Destroyed
Copy link
Member Author

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (but it's my PR originally, so I can't outright approve) ✅

@mesellings mesellings self-requested a review January 21, 2025 15:54
mesellings
mesellings previously approved these changes Jan 21, 2025
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions github-actions bot temporarily deployed to camunda-docs January 21, 2025 16:07 Destroyed
@mesellings mesellings removed the hold This issue is parked, do not merge. label Jan 21, 2025
pepopowitz
pepopowitz previously approved these changes Jan 21, 2025
Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review, nothing blocking.

src/css/custom.css Outdated Show resolved Hide resolved
src/css/custom.css Outdated Show resolved Hide resolved
src/theme/ColorModeToggle/index.js Outdated Show resolved Hide resolved
@pepopowitz
Copy link
Collaborator

@pepopowitz Let me know if this has any impaact on your docusaurus 3 migration?

@mesellings I don't think so, but even if it does, don't wait for me. I'm weeks out from merging that.

@mesellings mesellings dismissed stale reviews from pepopowitz and themself via 5a198ff January 22, 2025 09:41
@github-actions github-actions bot temporarily deployed to camunda-docs January 22, 2025 09:55 Destroyed
@mesellings mesellings self-requested a review January 24, 2025 08:50
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mesellings mesellings merged commit 5a4fad3 into main Jan 24, 2025
9 checks passed
@mesellings mesellings deleted the dark-mode-maybe branch January 24, 2025 08:51
@github-actions github-actions bot temporarily deployed to camunda-docs January 24, 2025 08:53 Destroyed
Copy link
Contributor

The preview environment relating to the commit 46cf1f9 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4510/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR kind/enhancement Issues related with enhancing existing documentation or the documentation structure (nice to have)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants