Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add vale rules for wording #4861
base: main
Are you sure you want to change the base?
WIP: add vale rules for wording #4861
Changes from 1 commit
7061c57
ede7402
600319c
b73f65e
d3990bc
b3b1586
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add "docker compose", as in the command (all lowercase)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if that's written intentionally in code, as a terminal command, will this get flagged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will get flagged -- similar to my lack of "javascript" currently. There are a few threads online discussing how we can ignore code blocks, but I may open this as a subsequent issue so I can do some research and testing on what that looks like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these apply to the Optimize docs as well? Adding them to the
styles/camunda/docsInstance
folder means they'll only apply to the main docs instance.I think you want to move them to the
styles/camunda/all
folder instead, so that they apply to both the main docs instance and the Optimize instance.This file was deleted.
This file was deleted.
This file was deleted.