Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding possible configuration variables for identity and also linked it to the gateway configuration #4863

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

itsnuyen
Copy link

@itsnuyen itsnuyen commented Jan 16, 2025

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Jan 16, 2025

👋 🤖 🤔 Hello, @jonathanlukas! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
  • versioned_docs/version-8.6/self-managed/zeebe-deployment/configuration/gateway.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

itsnuyen and others added 4 commits January 17, 2025 08:47
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good first iteration! Please reach out to me to discuss my comments :)

itsnuyen and others added 2 commits January 17, 2025 13:55
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@itsnuyen itsnuyen marked this pull request as ready for review January 22, 2025 12:25
Copy link
Contributor

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool next iteration.

I submitted some small adjustments, maybe the formatter needs to run after they are applied...

I also removed the comment "This setting can also be overridden using the environment variable" as it was only present in some properties.

We could maybe ask the @camunda/tech-writers team whether they have a strategy on how to display this very generic information (as environment variables do always override yaml properties). If not, we could add it above the table as a single sentence.

itsnuyen and others added 2 commits January 22, 2025 14:28
Co-authored-by: Jonathan Lukas <jonathan.lukas@camunda.com>
…nfiguration-variables.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jonathanlukas and others added 2 commits January 23, 2025 13:31
…nfiguration-variables.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jonathanlukas jonathanlukas self-requested a review January 23, 2025 12:41
Copy link
Contributor

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

After @Ben-Sheppard has approved, we need to copy the changes back to 8.4 and 8.5

We should also hold the PR open until we know 100% that 8.7 will contain the same identity arch.

Then, we can move it to /next as well

@akeller akeller added component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed low prio There is no urgency with this change. labels Jan 24, 2025
@akeller
Copy link
Member

akeller commented Jan 24, 2025

We should also hold the PR open until we know 100% that 8.7 will contain the same identity arch.

Then, we can move it to /next as well

We'll need validation from the Identity team (I see @Ben-Sheppard is already tagged!) because most Identity topics are rolling to 8.8.

@akeller akeller requested a review from a team January 24, 2025 20:36
@akeller akeller added the component:identity Issues related with Identity project label Jan 24, 2025
@Ben-Sheppard
Copy link
Contributor

Hey @jonathanlukas and @akeller - thats correct, we will have the old Identity architecture available in 8.7 so these configuration changes are still relevant there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:identity Issues related with Identity project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed low prio There is no urgency with this change.
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

4 participants