-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding possible configuration variables for identity and also linked it to the gateway configuration #4863
base: main
Are you sure you want to change the base?
Conversation
…it to the gateway configuration
👋 🤖 🤔 Hello, @jonathanlukas! Did you make your changes in all the right places? These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…the updated configuration parameters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good first iteration! Please reach out to me to discuss my comments :)
docs/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.4/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.5/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/zeebe-deployment/configuration/gateway.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.4/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.5/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
docs/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
docs/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
…s well as formating
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool next iteration.
I submitted some small adjustments, maybe the formatter needs to run after they are applied...
I also removed the comment "This setting can also be overridden using the environment variable" as it was only present in some properties.
We could maybe ask the @camunda/tech-writers team whether they have a strategy on how to display this very generic information (as environment variables do always override yaml properties). If not, we could add it above the table as a single sentence.
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonathan Lukas <jonathan.lukas@camunda.com>
…nfiguration-variables.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
Outdated
Show resolved
Hide resolved
…nfiguration-variables.md
…nfiguration-variables.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
After @Ben-Sheppard has approved, we need to copy the changes back to 8.4 and 8.5
We should also hold the PR open until we know 100% that 8.7 will contain the same identity arch.
Then, we can move it to /next as well
We'll need validation from the Identity team (I see @Ben-Sheppard is already tagged!) because most Identity topics are rolling to 8.8. |
Hey @jonathanlukas and @akeller - thats correct, we will have the old Identity architecture available in 8.7 so these configuration changes are still relevant there |
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).