Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectors: Add hint about merging set cookie headers #4875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

connectors: Add hint about merging set cookie headers #4875

wants to merge 1 commit into from
+8 −0

Conversation

ztefanie
Copy link

Description

Added hint about new feature of grouping headers

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@ztefanie ztefanie requested a review from johnBgood January 20, 2025 08:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@ztefanie ztefanie mentioned this pull request Jan 20, 2025
Merged
1 task
@ztefanie ztefanie force-pushed the connectors-add-hint-about-header-grouping branch from a2297f2 to 7d653d2 Compare January 20, 2025 10:57
@ztefanie ztefanie force-pushed the connectors-add-hint-about-header-grouping branch from 7d653d2 to 0d571f5 Compare January 20, 2025 12:28
johnBgood
johnBgood approved these changes Jan 20, 2025
View reviewed changes
docs/components/connectors/protocol/rest.md
@@ -234,6 +234,10 @@ The following fields are available in the `response` variable:
Starting from version 8.7.0, the REST Connector supports storing the response as a document. See additional details and limitations in [document handling](/components/concepts/document-handling.md).
:::

:::note
If your endpoint returns multiple Set-Cookie headers and you need to capture all of them, set `groupSetCookieHeaders` to `true` to aggregate them into a list.
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can we show the returned list as an example (this would help customers figure out the separator we used etc)

@akeller akeller added the component:connectors Issues related to the connectors project. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnBgood johnBgood johnBgood approved these changes

Assignees

@ztefanie ztefanie

Labels
component:connectors Issues related to the connectors project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ztefanie @johnBgood @akeller