Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share feedback widget looks broken #4213

Closed
nikku opened this issue Mar 26, 2024 · 6 comments · Fixed by #4215
Closed

Share feedback widget looks broken #4213

nikku opened this issue Mar 26, 2024 · 6 comments · Fixed by #4215
Assignees
@nikku
Labels
bug Something isn't working
Milestone
M75

Comments

@nikku
Copy link
Member

nikku commented Mar 26, 2024 •
edited
Loading

Describe the bug

image

Steps to reproduce

Open share feedback widget. See that it looks oddly formatted.

Expected behavior

No multi-line (checkbox + label).

Environment

  • OS: Linux
  • Camunda Modeler Version: v5.22.0 (works in v5.21.0)
  • Execution Platform: Any
  • Installed plug-ins: None

Additional context

No response
@nikku nikku added the bug Something isn't working label Mar 26, 2024
@nikku
Copy link
Member Author

nikku commented Mar 27, 2024

Same for deploy widget:

image

@nikku
Copy link
Member Author

nikku commented Mar 27, 2024

Root cause: This broke with this potentially, at least with the commit:

deps: update deps

nikku added a commit that referenced this issue Mar 27, 2024
@nikku
deps(client): pin formik to v2.0.4
59077c9 
fix(client): share and deploy widgets look broken

  Closes #4213
@nikku nikku mentioned this issue Mar 27, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 27, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed needs review Review pending in progress Currently worked on labels Mar 27, 2024
@nikku nikku added this to the M75 milestone Mar 27, 2024
@nikku
Copy link
Member Author

nikku commented Mar 27, 2024

Addressed via #4215

@barmac barmac mentioned this issue Mar 27, 2024
Closed
37 tasks
@barmac
Copy link
Collaborator

barmac commented Mar 27, 2024

I can reproduce the issue. The direct reason is that the form-control class is not applied in the RC.

@barmac
Copy link
Collaborator

barmac commented Mar 27, 2024

Related to this unintentional breaking change: jaredpalmer/formik#3883

barmac pushed a commit that referenced this issue Mar 27, 2024
@nikku @barmac
deps(client): pin formik to v2.0.4
dcc6ff8 
fix(client): share and deploy widgets look broken

  Closes #4213
@barmac
Copy link
Collaborator

barmac commented Mar 27, 2024

Closed via #4215

@barmac barmac closed this as completed Mar 27, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Projects
None yet
Milestone
M75
Development

Successfully merging a pull request may close this issue.

deps(client): pin formik to v2.0.4 camunda/camunda-modeler
2 participants
@nikku @barmac