Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(client): pin formik to v2.0.4 #4215

Merged
merged 3 commits into from
Mar 27, 2024
Merged

deps(client): pin formik to v2.0.4 #4215

merged 3 commits into from
Mar 27, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 27, 2024

Two issues:

  • styles broken, fixed via 59077c9
  • even after reverting formik bump I saw a forced app reload on C7 diagram (resources/diagram/simple.bpmn) deploy dialog open, fixed via 721ca1e

screenshot TNty9q
screenshot wDpcd8
screenshot GLbF7O


Closes #4213

fix(client): share and deploy widgets look broken

  Closes #4213
@nikku nikku added this to the M75 milestone Mar 27, 2024
@nikku nikku requested review from philippfromme and barmac March 27, 2024 06:25
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 27, 2024
@nikku nikku marked this pull request as draft March 27, 2024 06:41
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Mar 27, 2024
@nikku nikku marked this pull request as ready for review March 27, 2024 06:57
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 27, 2024
@nikku nikku removed this from the M75 milestone Mar 27, 2024
@nikku nikku changed the base branch from develop to main March 27, 2024 09:29
@barmac
Copy link
Collaborator

barmac commented Mar 27, 2024

This fixes the issue, but notice also the analysis in #4213 (comment)

@barmac barmac merged commit cf33b61 into main Mar 27, 2024
11 of 13 checks passed
@barmac barmac deleted the formik-revert branch March 27, 2024 09:48
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share feedback widget looks broken
2 participants