-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bpmnlint recommended rules built-in #3289
base: develop
Are you sure you want to change the base?
Conversation
CC @YanaSegal |
UI improvement we discussed already documented via https://github.com/bpmn-io/internal-docs/issues/665 CC @YanaSegal. |
I've tried to push out an initial version of this thing as a preview, hidden behind a feature toggle. Unfortunately I failed in the timebox I put for myself. What I wanted to accomplish: if (Flags.get('bpmnlint-recommended-rules', true)) {
registerClientPlugin(recommendedRules, 'lintRules.bpmn');
registerClientPlugin(recommendedRules, 'lintRules.cloud-bpmn');
} Why this failed: We eagerly load all internal plug-ins and cannot use flags that early in the resolution. We could load plug-ins after flags (and meta-data) are initialized; that would be my expected behavior. But given how we currently structure things that is not a quick task. |
I agree with that. |
c783168
to
b6e1281
Compare
Should do, as soon as we have settings. |
Adds bpmnlint recommended rules as part of the modeler core:
Can be tried out via the following artifacts:
Child of https://github.com/bpmn-io/internal-docs/issues/657.