Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed untyped defs in cloudinit analyze #5823

Conversation

abdulganiyy
Copy link

@abdulganiyy abdulganiyy commented Oct 14, 2024

Related to #5445

Proposed Commit Message

fix: fix untyped-defs in /analyze

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb added the CLA signed The submitter of the PR has signed the CLA label Oct 14, 2024
@holmanb
Copy link
Member

holmanb commented Oct 14, 2024

@abdulganiyy Thanks for this contribution!

Our CI jobs picked up that there is a syntax error in cloudinit/analyze/__init__.py. See the failed jobs for more detail.

@abdulganiyy
Copy link
Author

@abdulganiyy Thanks for this contribution!

Our CI jobs picked up that there is a syntax error in cloudinit/analyze/__init__.py. See the failed jobs for more detail.

Thank you. I’ll take a look at the failed CI jobs and review the syntax error. I'll follow up once I’ve identified and resolved the issue.

@abdulganiyy
Copy link
Author

@holmanb I have fixed the error.

Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdulganiyy This may resolve untyped-defs, but it introduces other errors. We cannot merge this until the new mypy errors are resolved.

Copy link

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Nov 27, 2024
@github-actions github-actions bot closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed The submitter of the PR has signed the CLA stale-pr Pull request is stale; will be auto-closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants