-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed untyped defs in cloudinit analyze #5823
fixed untyped defs in cloudinit analyze #5823
Conversation
@abdulganiyy Thanks for this contribution! Our CI jobs picked up that there is a syntax error in |
Thank you. I’ll take a look at the failed CI jobs and review the syntax error. I'll follow up once I’ve identified and resolved the issue. |
@holmanb I have fixed the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdulganiyy This may resolve untyped-defs, but it introduces other errors. We cannot merge this until the new mypy errors are resolved.
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
Related to #5445
Proposed Commit Message
Additional Context
Test Steps
Merge type