-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu/oracular 24.4.x #5980
Merged
TheRealFalcon
merged 14 commits into
canonical:ubuntu/oracular-24.4.x
from
TheRealFalcon:ubuntu/oracular-24.4.x
Jan 17, 2025
Merged
Ubuntu/oracular 24.4.x #5980
TheRealFalcon
merged 14 commits into
canonical:ubuntu/oracular-24.4.x
from
TheRealFalcon:ubuntu/oracular-24.4.x
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous way was preventing passing multiple (or no) args.
get_meta_doc() is no longer used, but there may be custom modules that still try to reference it. Don't break them.
If the server is busy, no need to fail. Add type hints to adjacent code paths and necessary refactors. Fixes canonicalGH-5577 --------- Co-authored-by: Brett Holman <brett.holman@canonical.com>
There are use cases where we may want to recover or not treat a failure of this function as an error. This change lets the caller decide what to do. Logging was added to callsites that didn't already have it. Fixes canonicalGH-5971
…anonical#5976) The function "_should_wait_via_user_data()" wasn't properly handling user data that has a header that starts with #cloud-config, but isn't cloud-config, like #cloud-config-archive Fixes canonicalGH-5975
Bump the version in cloudinit/version.py to 24.4.1 and update ChangeLog.
holmanb
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change requested, otherwise looks good!
debian/changelog
Outdated
@@ -1,3 +1,17 @@ | |||
cloud-init (24.4.1-0ubuntu0~24.10.1) plucky; urgency=medium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says plucky but should say oracular.
TheRealFalcon
force-pushed
the
ubuntu/oracular-24.4.x
branch
from
January 17, 2025 19:47
9396120
to
d5b04a2
Compare
holmanb
approved these changes
Jan 17, 2025
TheRealFalcon
merged commit Jan 17, 2025
d5b04a2
into
canonical:ubuntu/oracular-24.4.x
20 of 21 checks passed
MyhostRL
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.