Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu/oracular 24.4.x #5980

Conversation

TheRealFalcon
Copy link
Member

No description provided.

holmanb and others added 13 commits January 13, 2025 15:59
The previous way was preventing passing multiple (or no) args.
get_meta_doc() is no longer used, but there may be custom modules that
still try to reference it. Don't break them.
If the server is busy, no need to fail.
Add type hints to adjacent code paths
and necessary refactors.

Fixes canonicalGH-5577

---------

Co-authored-by: Brett Holman <brett.holman@canonical.com>
There are use cases where we may want to recover or not treat a failure
of this function as an error. This change lets the caller decide what
to do.

Logging was added to callsites that didn't already have it.

Fixes canonicalGH-5971
…anonical#5976)

The function "_should_wait_via_user_data()" wasn't properly
handling user data that has a header that starts with
#cloud-config, but isn't cloud-config, like #cloud-config-archive

Fixes canonicalGH-5975
Bump the version in cloudinit/version.py to 24.4.1 and
update ChangeLog.
@github-actions github-actions bot added the packaging Supplemental package review requested label Jan 16, 2025
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change requested, otherwise looks good!

debian/changelog Outdated
@@ -1,3 +1,17 @@
cloud-init (24.4.1-0ubuntu0~24.10.1) plucky; urgency=medium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says plucky but should say oracular.

@TheRealFalcon TheRealFalcon force-pushed the ubuntu/oracular-24.4.x branch from 9396120 to d5b04a2 Compare January 17, 2025 19:47
@TheRealFalcon TheRealFalcon merged commit d5b04a2 into canonical:ubuntu/oracular-24.4.x Jan 17, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Supplemental package review requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants