Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Run ansible with run_user instead of root for distro install_method #5986

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: Run ansible with run_user instead of root for distro install_method #5986

merged 1 commit into from
Feb 3, 2025

Conversation

shaerpour
Copy link
Contributor

Proposed Commit Message

fix: Run ansible with run_user instead of root for distro install_method

Added constructor for AnsiblePullDistro that handels which user to run
playbook with

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Fixes GH-4092

@shaerpour shaerpour force-pushed the ansible-distro-user-ignore branch from 5075eff to b307f4a Compare January 29, 2025 10:27
@TheRealFalcon TheRealFalcon self-assigned this Feb 3, 2025
TheRealFalcon
TheRealFalcon approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution!

@TheRealFalcon TheRealFalcon merged commit d9df242 into canonical:main Feb 3, 2025
22 checks passed
@shaerpour shaerpour deleted the ansible-distro-user-ignore branch February 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees

@TheRealFalcon TheRealFalcon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible run_user ignored when distro install method is used
2 participants
@shaerpour @TheRealFalcon