Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizations for docker #337

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

optimizations for docker #337

wants to merge 4 commits into from

Conversation

kmou424
Copy link

@kmou424 kmou424 commented Oct 24, 2024

  1. use /data as default data dir (a temporary workaround, use other environment variable that implemented in backend to set data dir will be better)
  2. set more permissive permissions to allow any user or group to make changes in /app and /data (now we can use --user $(id -u):$(id -g) to set user and group in docker)
  3. optimize docker build process, now you can completely build project with docker

@kmou424 kmou424 marked this pull request as draft October 24, 2024 15:40
@kmou424 kmou424 marked this pull request as ready for review October 24, 2024 17:09
@kmou424 kmou424 marked this pull request as draft October 25, 2024 11:09
@kmou424
Copy link
Author

kmou424 commented Oct 25, 2024

need fix up the lost part of artifacts

TypeError: s is not a function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant