Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): QR code for multi sig not updating #937

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

sdisalvo-crd
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd commented Jan 30, 2025

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1771

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Browser

Before
30012025100215.mp4
After
30012025100556.mp4

@sdisalvo-crd sdisalvo-crd self-assigned this Jan 30, 2025
@sdisalvo-crd sdisalvo-crd requested review from iFergal and removed request for iFergal January 30, 2025 10:05
@sdisalvo-crd sdisalvo-crd marked this pull request as ready for review January 30, 2025 10:11
@sdisalvo-crd sdisalvo-crd requested review from jorgenavben and removed request for jimcase January 30, 2025 10:11
@sdisalvo-crd sdisalvo-crd merged commit 2d90fb3 into main Feb 4, 2025
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the fix/DTIS-1771-QR-code-for-multi-sig-not-updating branch February 4, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants