Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teuthology lock is stuck if vm create failed #2022

Merged
merged 3 commits into from
Jan 30, 2025
Merged

teuthology lock is stuck if vm create failed #2022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62f4df3
lock/cli: don't update inventory if failed to create a vm
Jan 10, 2025
d9f0a9a
lock/ops: don't misguide user while waiting for vms up
Jan 16, 2025
3180b7c
provision/downburst: log multiline stderr on error
Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions teuthology/lock/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,14 @@ def main(ctx):
# Update keys last
updatekeys_machines = list()
else:
machines_to_update.append(machine)
ops.update_nodes([machine], True)
teuthology.provision.create_if_vm(
created = teuthology.provision.create_if_vm(
ctx,
misc.canonicalize_hostname(machine),
)
# do not try to update inventory if failed to create vm
if created:
machines_to_update.append(machine)
with teuthology.parallel.parallel() as p:
ops.update_nodes(reimage_machines, True)
for machine in reimage_machines:
Expand Down
1 change: 0 additions & 1 deletion teuthology/lock/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,6 @@ def block_and_lock_machines(ctx, total_requested, machine_type, reimage=True, tr
loopcount += 1
time.sleep(10)
keys_dict = misc.ssh_keyscan(vmlist)
log.info('virtual machine is still unavailable')
if loopcount == 40:
loopcount = 0
log.info('virtual machine(s) still not up, ' +
Expand Down
5 changes: 3 additions & 2 deletions teuthology/provision/downburst.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,9 @@ def create(self):
self.destroy()
else:
success = False
log.info("Downburst failed on %s: %s" % (
self.name, stderr.strip()))
log.error("Downburst failed on %s" % self.name)
for i in stderr.split('\n'):
log.error(f">>> {i}")
break
return success

Expand Down