Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13345: Enable example test for OrderedPropertiesCheck #16141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaikhu
Copy link
Contributor

@shaikhu shaikhu commented Jan 10, 2025

Issue #13345
Enable examples tests for OrderedPropertiesCheck

  • .txt converted to .java + .properties
  • xml updated
  • enabled example tests
  • used new method in AbstractModuleTestSupport

https://checkstyle.org/checks/misc/orderedproperties.html#Examples

@shaikhu shaikhu marked this pull request as draft January 10, 2025 16:28
@shaikhu shaikhu changed the title Issue #13445: Enable example test for OrderedPropertiesCheck Issue #13345: Enable example test for OrderedPropertiesCheck Jan 10, 2025
@romani
Copy link
Member

romani commented Jan 10, 2025

GitHub, generate website

@shaikhu shaikhu marked this pull request as ready for review January 10, 2025 17:01
@shaikhu
Copy link
Contributor Author

shaikhu commented Jan 10, 2025

@romani The CI failures are because of the following checkstyle violations. Any idea how if/how I can fix them?

ERROR�[m] src/main/java/org/xwiki/container/servlet/SetThreadNameServletRequestListener.java:[32] (sizes) LineLength: Line is longer than 120 characters (found 121).

ERROR�[m] src/main/java/org/xwiki/container/servlet/XWikiServletContextListener.java:[58] (sizes) LineLength: Line is longer than 120 characters (found 121).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants