Skip to content

Commit

Permalink
e2e: Set the number of retries to 1 in the grpc client
Browse files Browse the repository at this point in the history
grpc/grpc-go#7905 requires that the number of retres
to greater than 1. This is part of google.golang.org/grpc@v1.70.0 and this
update makes tests to fail.

Signed-off-by: Anastasios Papagiannis <anastasios.papagiannis@isovalent.com>
  • Loading branch information
tpapagian committed Jan 24, 2025
1 parent 2dfa64a commit 455458f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/e2e/helpers/grpc/grpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ func WaitForTracingPolicy(ctx context.Context, policyName string) error {
maxTries := 20
for podName, grpcPort := range tetraPorts {
addr := fmt.Sprintf("127.0.0.1:%d", grpcPort)
// https://github.com/grpc/grpc-go/pull/7905 requires the number of retries to
// be greater than 1 in google.golang.org/grpc v1.7.0.
// We already do that + 1 in retryPolicy() so it is safe to make that 1.
common.Retries = 1
// NB(kkourt): maybe it would make sense to cache the grpc connections in the
// context, but we keep things simple for now.
c, err := common.NewClient(ctx, addr, 10*time.Second)
Expand Down

0 comments on commit 455458f

Please sign in to comment.