Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.1 backport] workflows: use GitHub arm64 runners instead of actuated #3140

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Nov 19, 2024

Backport of #3034 for deps update to work (like #3136).

@mtardy mtardy added kind/backport This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI. labels Nov 19, 2024
@mtardy mtardy requested review from willfindlay and a team as code owners November 19, 2024 12:31
Copy link
Contributor

@kevsecurity kevsecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away

@mtardy
Copy link
Member Author

mtardy commented Nov 19, 2024

This one test has been failing twice in a row here on the runner #3144.

[ upstream commit 1e9b9c7 ("pkg/sensors/tracing: fix enforcer
security tests") ]

Because of root-images update in previous commit, the enforcer security
tests started failing, after investigation we realized that the
difference was that the old image mounted /tmp on the disk fs and the
new one with tmpfs. Then the direct-write-tester.c program was failing
using O_DIRECT (because apparently it fails on tmpfs). It failed
silently on recent linux versions however because O_DIRECT on tmpfs
might just be a noop.

/var/tmp should be backed by disk so it should be a fix for our issue.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
[ upstream commit 19a0cc8 ("pkg/sensors/tracing: fix LSM open
tests") ]

Very similar to 1e9b9c7.

It was merged just before that fix and was not yet rebased with the new
base image so it escaped the test failure.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy force-pushed the pr/mtardy/backport-v1.1-arm64-runners branch from 989cf7e to e34f150 Compare November 20, 2024 15:21
mtardy and others added 3 commits November 20, 2024 21:24
[ upstream commit 58a7a7c ("tester-progs: do not define O_DIRECT manually") ]

O_DIRECT is not posix so we need to add _GNU_SOURCE

Co-authored-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
[ upstream commit 65ef270 ("workflows: use GitHub arm64 runners
instead of actuated") ]

CNCF stopped funding actuated arm64 runners but GitHub now proposes
their own runners part of the GitHub offering.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
[ upstream commit 0089022 ("e2e tests: skip label test on ARM") ]

e2e tests: skip label test on ARM

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@olsajiri olsajiri force-pushed the pr/mtardy/backport-v1.1-arm64-runners branch from e34f150 to cf101b8 Compare November 20, 2024 21:24
@mtardy mtardy merged commit f1b2c51 into v1.1 Nov 20, 2024
38 checks passed
@mtardy mtardy deleted the pr/mtardy/backport-v1.1-arm64-runners branch November 20, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backport This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants