Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 2 broken links in README #1358

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

naltmann
Copy link

@lazysegtree
Copy link

LGTM. Verified that old link doesn't works, and new one works. Thanks @naltmann

@lazysegtree
Copy link

@naltmann. There is one more dead link. Could you also fix that in this PR ?
Create a Tunnel with [these instructions](https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/create-tunnel)
See - #1375

@lazysegtree
Copy link

lazysegtree commented Jan 19, 2025

Tagging you @chungthuang as you are active on this repo. This is a small fix in ReadMe for dead link. We dont need to delay to merge this.
If @naltmann is not actively looking at this anymore, we could create a separate PR. I could do that if you want.

Fix broken link to create tunnel page
@naltmann naltmann changed the title Replace broken link to WARP client Replace 2 broken links in README Jan 19, 2025
@naltmann
Copy link
Author

I think I was able to update the PR with the additional link fix.

@lazysegtree
Copy link

Thanks @naltmann. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants