Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: max_streams in ConnectionRefInner is not synced #434

Closed
wants to merge 1 commit into from
Closed

fix: max_streams in ConnectionRefInner is not synced #434

wants to merge 1 commit into from

Conversation

swimablefish
Copy link

@swimablefish swimablefish commented Oct 17, 2024 •
edited
Loading

Fix the bug #401

The value of the max stream could be updated by Settings frame in the h2 crate.
Pingora needs to get the updated value instead of storing it in its struct

@eaufavor eaufavor added the bug Something isn't working label Oct 18, 2024
@eaufavor
Copy link
Member

eaufavor commented Oct 18, 2024 •
edited
Loading

Fixed in a slightly different way 7419b19.

Thanks for the PR regardless.

@eaufavor eaufavor closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eaufavor eaufavor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swimablefish @eaufavor