Merge pull request #3295 from cloudflare/dlapid/fix_trace_lifetime2

Dont mv out of arrayPtr in sendTracesToExportedHandler
cloudflare · Jan 6, 2025 · 1a12caa · 1a12caa
2 parents d8de55a + 80f2d8f
commit 1a12caa
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/workerd/api/trace.c++ b/src/workerd/api/trace.c++
@@ -659,7 +659,7 @@ kj::Promise<void> sendTracesToExportedHandler(kj::Own<IoContext::IncomingRequest
   auto nonEmptyTraces = kj::Vector<kj::Own<Trace>>(kj::size(traces));
   for (auto& trace: traces) {
     if (trace->eventInfo != kj::none) {
-      nonEmptyTraces.add(kj::mv(trace));
+      nonEmptyTraces.add(kj::addRef(*trace));
     }
   }