do not throw on setNoDelay

cloudflare · Jan 14, 2025 · 46ede10 · 46ede10
1 parent c87e32c
commit 46ede10
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/node/net.ts b/src/node/net.ts
@@ -748,10 +748,11 @@ Socket.prototype.connect = function (
 
 Socket.prototype.setNoDelay = function (
   this: SocketClass,
-  enable?: boolean
+  _enable?: boolean
 ): SocketClass {
-  if (!enable) return this;
-  throw new ERR_INVALID_ARG_VALUE('enable', enable, 'is not supported');
+  // Ignore this for now.
+  // Cloudflare connect() does not support this.
+  return this;
 };
 
 Socket.prototype.setKeepAlive = function (
@@ -1330,7 +1331,6 @@ export function connect(...args: unknown[]): SocketClass {
   const normalized = normalizeArgs(args);
   const options = normalized[0] as SocketOptions;
   // @ts-expect-error TS7009 Required for type usage
-
   const socket: SocketClass = new Socket(options);
   if (options.timeout) {
     socket.setTimeout(options.timeout);