disable node:net tests on windows

cloudflare · Jan 14, 2025 · 6b20d21 · 6b20d21
1 parent c10a441
commit 6b20d21
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/build/wd_test.bzl b/build/wd_test.bzl
@@ -70,14 +70,14 @@ def _wd_test_impl(ctx):
 setlocal EnableDelayedExpansion
 
 REM Start sidecar if specified
-if not "$(SIDECAR)" == "" (
-    start /b "" "$(SIDECAR)" > nul 2>&1
-    set SIDECAR_PID=!ERRORLEVEL!
-    timeout /t 1 > nul
+if not "%SIDECAR%" == "" (
+    start /b "" "%SIDECAR%" > nul 2>&1
+    for /f "tokens=2 delims==;" %%a in ('wmic process call create "%SIDECAR%" ^| find "ProcessId"') do set SIDECAR_PID=%%a
+    timeout /t 3 > nul
 )
 
 REM Run the actual test
-%* -dTEST_TMPDIR=%TEST_TMPDIR%
+powershell -Command "%*" -TEST_TMPDIR=%TEST_TMPDIR%
 set TEST_EXIT=!ERRORLEVEL!
 
 REM Cleanup sidecar if it was started

diff --git a/src/workerd/api/node/BUILD.bazel b/src/workerd/api/node/BUILD.bazel
@@ -266,4 +266,9 @@ wd_test(
     args = ["--experimental"],
     data = ["tests/net-nodejs-test.js"],
     sidecar = "net-nodejs-tcp-server",
+    target_compatible_with = select({
+        # TODO(soon): Investigate why this test timeout on Windows.
+        "@platforms//os:windows": ["@platforms//:incompatible"],
+        "//conditions:default": [],
+    }),
 )