remove unnecessary compat flag

cloudflare · Jan 13, 2025 · c197b93 · c197b93
1 parent 9380b4c
commit c197b93
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 18 deletions.
diff --git a/src/node/internal/compatibility-flags.d.ts b/src/node/internal/compatibility-flags.d.ts
@@ -31,4 +31,3 @@ export const workerdExperimental: boolean;
 export const durableObjectGetExisting: boolean;
 export const vectorizeQueryMetadataOptional: boolean;
 export const nodeJsZlib: boolean;
-export const nodeJsCompatNet: boolean;
diff --git a/src/node/net.ts b/src/node/net.ts
@@ -27,14 +27,6 @@
 
 import inner from 'cloudflare-internal:sockets';
 
-import { default as compatFlags } from 'workerd:compatibility-flags';
-
-if (!compatFlags.nodeJsCompatNet || !compatFlags.workerdExperimental) {
-  throw new Error(
-    'To use the node:net built-in module, set the nodejs_compat_net flag'
-  );
-}
-
 import {
   ERR_INVALID_ARG_VALUE,
   ERR_INVALID_ARG_TYPE,

diff --git a/src/workerd/api/node/tests/net-nodejs-test.wd-test b/src/workerd/api/node/tests/net-nodejs-test.wd-test
@@ -8,7 +8,7 @@ const unitTests :Workerd.Config = (
           (name = "worker", esModule = embed "net-nodejs-test.js")
         ],
         compatibilityDate = "2025-01-09",
-        compatibilityFlags = ["nodejs_compat", "nodejs_compat_net", "experimental"],
+        compatibilityFlags = ["nodejs_compat"],
       )
     ),
     ( name = "internet", network = ( allow = ["private"] ) ),

diff --git a/src/workerd/io/compatibility-date.capnp b/src/workerd/io/compatibility-date.capnp
@@ -679,12 +679,4 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
       $compatDisableFlag("cache_no_cache_disabled")
       $experimental;
   # Enables the use of cache: no-cache in the fetch api.
-
-  nodeJsCompatNet @71 :Bool
-      $compatEnableFlag("nodejs_compat_net")
-      $compatDisableFlag("no_nodejs_compat_net")
-      $compatEnableDate("2025-06-01")
-      $experimental;
-  # When the nodejs_compat or nodejs_compat v2 flags are enabled, the nodejs_compat_net
-  # flag determines if the node:net built-in module is also available.
 }