Implement node:crypto X509Certificate #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/node-crypto-x509cert
branch
from
701ea59 to
e9c3c4c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
jasnell
force-pushed
the
jsnell/node-crypto-x509cert
branch
3 times, most recently
from
28f3c5c to
45b8f44
Compare
jasnell
changed the title
jasnell
force-pushed
the
jsnell/node-crypto-x509cert
branch
from
45b8f44 to
d761644
Compare
jasnell
force-pushed
the
jsnell/node-crypto-x509cert
branch
from
d761644 to
cfcad57
Compare
garrettgu10
approved these changes
Jul 10, 2024
src/node/internal/crypto_x509.ts
Outdated
| #handle?: cryptoImpl.X509Certificate = undefined; | ||
| #state = new Map(); | ||
|
|
||
| constructor(buffer: ArrayBufferView | ArrayBuffer | cryptoImpl.X509Certificate) { |
There was a problem hiding this comment.
Why is string not included here?
jasnell
force-pushed
the
jsnell/node-crypto-x509cert
branch
2 times, most recently
from
702b799 to
0449bf1
Compare
jasnell
force-pushed
the
jsnell/node-crypto-x509cert
branch
from
0449bf1 to
46f0f45
Compare
|
rebased with a couple additional tweaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
node:cryptoX509CertificateAPI