merge isAsciiWhitespace implementations #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/merge-is-ascii-whitespace
branch
3 times, most recently
from
f5810f1 to
e05c0ac
Compare
anonrig
force-pushed
the
yagiz/merge-is-ascii-whitespace
branch
from
e05c0ac to
c4b2d5e
Compare
anonrig
force-pushed
the
yagiz/merge-is-ascii-whitespace
branch
5 times, most recently
from
b2ed219 to
30f7bb5
Compare
fhanau
reviewed
Sep 25, 2024
fhanau
reviewed
Sep 25, 2024
fhanau
reviewed
Sep 25, 2024
anonrig
force-pushed
the
yagiz/merge-is-ascii-whitespace
branch
2 times, most recently
from
270c5f5 to
f943917
Compare
fhanau
reviewed
Sep 25, 2024
fhanau
reviewed
Sep 25, 2024
jasnell
reviewed
Sep 25, 2024
fhanau
reviewed
Sep 25, 2024
fhanau
reviewed
Sep 25, 2024
| return result; | ||
| }(); | ||
|
|
||
| constexpr bool isAsciiWhitespace(uint8_t c) noexcept { |
There was a problem hiding this comment.
Conceptually, this could affect performance – isAsciiWhitespace() does a single table lookup so having it defined in a different source file will make using it much slower based on needing a function call now. The compiler might just be able to inline it properly if LTO is enabled (such as with the downstream release build), so this is non-blocking.
There was a problem hiding this comment.
I moved the implementation to encoding.h and made it constexpr again. Since it is an extremely small fixed array, I don't think it would have any negative impact, but let me know if you disagree. I can change it back without any hassle.
anonrig
force-pushed
the
yagiz/merge-is-ascii-whitespace
branch
from
f943917 to
a5eae95
Compare
anonrig
force-pushed
the
yagiz/merge-is-ascii-whitespace
branch
from
a5eae95 to
413d5a5
Compare
jasnell
approved these changes
Sep 25, 2024
|
...just in case... |
fhanau
approved these changes
Sep 26, 2024
mikea
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges 2 implementations and introduces 2 new cc_library targets on bazel.