Add more jaeger spans in Python setup #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
approved these changes
Nov 6, 2024
dom96
approved these changes
Nov 6, 2024
src/pyodide/internal/python.ts
Outdated
| @@ -62,10 +62,10 @@ async function prepareWasmLinearMemory(Module: Module): Promise<void> { | |||
| mountSitePackages(Module, SITE_PACKAGES.rootInfo); | |||
| entropyMountFiles(Module); | |||
| Module.noInitialRun = !SHOULD_RESTORE_SNAPSHOT; | |||
| preloadDynamicLibs(Module); | |||
| Module.removeRunDependency('dynlibs'); | |||
| enterJaegerSpan('preloadDynamicLibs', () => preloadDynamicLibs(Module)); | |||
There was a problem hiding this comment.
Nit: this likely doesn't matter all that much but our convention so far has been snake_case for these
jasnell
approved these changes
Nov 6, 2024
hoodmane
force-pushed
the
hoodmane/more-jaeger-spans
branch
2 times, most recently
from
cfd1d05 to
3111586
Compare
hoodmane
force-pushed
the
hoodmane/more-jaeger-spans
branch
from
3111586 to
d9309dd
Compare
anonrig
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.