Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace symbolizer with kj built-in #3149

Merged
merged 1 commit into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions build/kj_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ def kj_test(
srcs = [src],
deps = [
"@capnp-cpp//src/kj:kj-test",
] + select({
"@platforms//os:windows": [],
"//conditions:default": ["@workerd//src/workerd/util:symbolizer"],
}) + deps,
] + deps,
linkopts = select({
"@//:use_dead_strip": ["-Wl,-dead_strip", "-Wl,-no_exported_symbols"],
"//conditions:default": [""],
Expand Down
5 changes: 2 additions & 3 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ default:
@just --list

pwd := `pwd`
clang_version := "18"

prepare:
cargo install gen-compile-commands
Expand All @@ -25,14 +24,14 @@ build-asan *args="//...":
just build {{args}} --config=asan --sandbox_debug

test *args="//...":
bazel test {{args}} --test_env=LLVM_SYMBOLIZER=llvm-symbolizer-{{clang_version}}
bazel test {{args}}

test-asan *args="//...":
just test {{args}} --config=asan

# e.g. just stream-test //src/cloudflare:cloudflare.capnp@eslint
stream-test args:
bazel test {{args}} --test_output=streamed --test_env=LLVM_SYMBOLIZER=llvm-symbolizer-{{clang_version}}
bazel test {{args}} --test_output=streamed

# e.g. just node-test zlib
node-test test_name:
Expand Down
5 changes: 1 addition & 4 deletions src/workerd/server/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,7 @@ wd_cc_binary(
"//src/workerd/util:autogate",
"//src/workerd/util:perfetto",
"@capnp-cpp//src/capnp:capnpc",
] + select({
"@platforms//os:windows": [],
"//conditions:default": ["@workerd//src/workerd/util:symbolizer"],
}),
],
)

wd_cc_library(
Expand Down
15 changes: 0 additions & 15 deletions src/workerd/util/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -143,21 +143,6 @@ wd_cc_library(
],
)

wd_cc_library(
name = "symbolizer",
srcs = ["symbolizer.c++"],
target_compatible_with = select({
"@platforms//os:windows": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
deps = [
":sentry",
"@capnp-cpp//src/kj",
],
alwayslink = 1,
)

wd_cc_library(
name = "own-util",
hdrs = ["own-util.h"],
Expand Down
174 changes: 0 additions & 174 deletions src/workerd/util/symbolizer.c++

This file was deleted.

Loading