Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add abstract base tracer class #3152

Merged
merged 1 commit into from
Nov 22, 2024
Merged

add abstract base tracer class #3152

merged 1 commit into from
Nov 22, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 21, 2024 •
edited
Loading

Adds a base tracer class which will be used for a passthrough tracer that doesn't communicate through rpc in bulk. Internal PR is coming.

@anonrig anonrig requested a review from jasnell November 21, 2024 19:57
jasnell
jasnell reviewed Nov 21, 2024
View reviewed changes
src/workerd/io/trace.h Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 21, 2024
View reviewed changes
src/workerd/io/trace.h Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Nov 21, 2024
View reviewed changes
src/workerd/io/trace.c++ Outdated Show resolved Hide resolved
@anonrig anonrig force-pushed the yagiz/add-base-tracer branch from 5f6f6e3 to fd37db0 Compare November 21, 2024 20:23
@anonrig anonrig force-pushed the yagiz/add-base-tracer branch from fd37db0 to 63535c4 Compare November 21, 2024 20:49
@anonrig anonrig marked this pull request as ready for review November 21, 2024 20:53
@anonrig anonrig requested review from a team as code owners November 21, 2024 20:53
jasnell
jasnell approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will need an internal PR given the change with the way setOutcome(...) is handled.

@jasnell jasnell merged commit 31c73bf into main Nov 22, 2024
15 of 16 checks passed
@jasnell jasnell deleted the yagiz/add-base-tracer branch November 22, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@ObsidianMinor ObsidianMinor Awaiting requested review from ObsidianMinor ObsidianMinor is a code owner automatically assigned from cloudflare/workers-runtime-1

@danlapid danlapid Awaiting requested review from danlapid danlapid is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @jasnell