[o11y] Add remaining R2 span tags

[fhanau]

Please consult the (internal) span definitions to review the added span tags. Input is welcome on API design for r2GetClient() and getHttpClientWithCallback().

[github-actions]

The generated output of @cloudflare/workers-types has been changed by this PR. If this is intentional, run bazel build //types && rm -rf types/generated-snapshot && cp -r bazel-bin/types/definitions types/generated-snapshot to update the snapshot. Alternatively, you can download the full generated types: https://github.com/cloudflare/workerd/actions/runs/12562988297/artifacts/2374928934

Full Type Diff

diff -r bazel-bin/types/definitions/experimental/index.d.ts types/generated-snapshot/experimental/index.d.ts
1680c1680
<   cache?: "no-store" | "no-cache";
---
>   cache?: "no-store";
1694c1694
<   cache?: "no-store" | "no-cache";
---
>   cache?: "no-store";
diff -r bazel-bin/types/definitions/experimental/index.ts types/generated-snapshot/experimental/index.ts
1688c1688
<   cache?: "no-store" | "no-cache";
---
>   cache?: "no-store";
1702c1702
<   cache?: "no-store" | "no-cache";
---
>   cache?: "no-store";

[mikea]

I feel that defining a simple struct UserTracing or something would go a long way for readability above (due to .method = "r2_delete"_kjc) and below because of maybe casts?

[fhanau]

To make sure I understand correctly – I assume you mean a struct like this:

struct UserTracing {
  kj::LiteralStringConst op;
  kj::LiteralStringConst method;
  kj::Maybe<kj::StringPtr> bucket;
  kj::Maybe<StringTagParams> extraTag;
};

Then we could pass parameters simply as {"r2_get"_kjc, "GetObject"_kjc, this->adminBucketName()}, but you prefer using this instead?

{
.op = "r2_get"_kjc,
.method = "GetObject"_kjc,
.bucket = this->adminBucketName()
}

FWIW I was able to clean up the Maybe<StringTagParams> wrappers in the last push.

[mikea]

I would prefer the version with names spelled out, yes. It is much easier to read and understand how r2_get is different from GetObject

[mikea]

I would prefer the version with names spelled out, yes. It is much easier to read and understand how r2_get is different from GetObject

[fhanau]

Merged via #3261.