Don't fail at upload time when module modifies sys.path

[hoodmane]

We try to execute all the top level imports but we don't execute changes to the path so we can get crashes.

[danlapid]

Why not just execute the top level scope?

[hoodmane]

Well the idea here is that we share the package snapshots between workers with the same top level imports. If you exec'd the top level scope, you'd have to use a dedicated snapshot just for that one worker.

[danlapid]

Well the idea here is that we share the package snapshots between workers with the same top level imports. If you exec'd the top level scope, you'd have to use a dedicated snapshot just for that one worker.

I see, so that's why you went with a try and ignore failures approach 👍

[hoodmane]

Also, this avoids the need to encrypt snapshots which makes debugging a lot easier.

[dom96]

A test for the case that this solves would be good

[hoodmane]

Yeah we'll need a validator test for this.

[hoodmane]

I guess we should add a test that exercises the validation code path from workerd so we don't have to rely on edgeworker tests for it.

[hoodmane]

Okay I am no longer reproducing any bug so I'll close this.