remove BigNumber

clrfund · Jan 14, 2024 · c94710b · c94710b
1 parent 197a624
commit c94710b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/vue-app/src/stores/__tests__/store-app.spec.ts b/vue-app/src/stores/__tests__/store-app.spec.ts
@@ -1,4 +1,3 @@
-import { BigNumber } from 'ethers'
 import { expect } from 'vitest'
 
 import { setActivePinia, createPinia } from 'pinia'
@@ -96,7 +95,7 @@ describe('Cart mutations', () => {
     const appStore = useAppStore()
     const item1 = createItem({ id: '0x1' })
     const item2 = createItem({ id: '0x2' })
-    appStore.$patch({ cart: [item1, item2], contribution: BigNumber.from(0) })
+    appStore.$patch({ cart: [item1, item2], contribution: BigInt(0) })
     appStore.removeCartItem(item1)
     expect(appStore.cart.length).to.equal(1)
     expect(appStore.cart[0].id).to.equal(item2.id)
@@ -105,7 +104,7 @@ describe('Cart mutations', () => {
   it('does not remove item that is not in cart', () => {
     const appStore = useAppStore()
     const item = createItem({ id: '0x1' })
-    appStore.$patch({ cart: [item], contribution: BigNumber.from(0) })
+    appStore.$patch({ cart: [item], contribution: BigInt(0) })
     const newItem = createItem({ id: '0x2' })
     expect(() => {
       appStore.removeCartItem(newItem)
@@ -128,7 +127,7 @@ describe('Cart mutations', () => {
     const appStore = useAppStore()
     const item1 = createItem({ id: '0x1' })
     const item2 = createItem({ id: '0x2' })
-    appStore.$patch({ cart: [item1, item2], contribution: BigNumber.from(1) })
+    appStore.$patch({ cart: [item1, item2], contribution: BigInt(1) })
     appStore.removeCartItem(item1)
     expect(appStore.cart.length).to.equal(2)
     expect(appStore.cart[0].amount).to.equal('0')
@@ -148,7 +147,7 @@ describe('Cart mutations', () => {
     const newItem2 = createItem({ id: '92' })
     appStore.$patch({
       cart: [...items, newItem1, newItem2],
-      contribution: BigNumber.from(1),
+      contribution: BigInt(1),
     })
     expect(appStore.cart.length).to.equal(MAX_CART_SIZE + 1)
 

diff --git a/vue-app/src/stores/app.ts b/vue-app/src/stores/app.ts
@@ -30,7 +30,7 @@ export type AppState = {
   cartEditModeSelected: boolean
   committedCart: CartItem[]
   cartLoaded: boolean
-  contribution: BigNumber | null
+  contribution: BigInt | null
   contributor: Contributor | null
   hasVoted: boolean
   currentRound: RoundInfo | null
@@ -146,7 +146,7 @@ export const useAppStore = defineStore('app', {
     },
     hasUserContributed: (state): boolean => {
       const userStore = useUserStore()
-      return !!userStore.currentUser && !!state.contribution && !state.contribution.isZero()
+      return !!userStore.currentUser && !!state.contribution && state.contribution !== BigInt(0)
     },
     operator: (): string => {
       return operator
@@ -348,7 +348,7 @@ export const useAppStore = defineStore('app', {
         throw new Error('item is not in the cart')
       } else if (this.contribution === null) {
         throw new Error('invalid operation')
-      } else if (this.contribution.isZero() || this.cart.length > MAX_CART_SIZE) {
+      } else if (this.contribution === BigInt(0) || this.cart.length > MAX_CART_SIZE) {
         this.cart.splice(itemIndex, 1)
       } else {
         // The number of MACI messages can't go down after initial submission