Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and replace rinkeby with goerli #517

Merged
merged 12 commits into from
Jul 4, 2022

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Jun 22, 2022

No description provided.

@yuetloo yuetloo self-assigned this Jun 22, 2022
@yuetloo yuetloo linked an issue Jun 22, 2022 that may be closed by this pull request
@yuetloo yuetloo marked this pull request as draft June 22, 2022 23:58
@yuetloo yuetloo changed the title Update documentation with new zkSnark parameter download instructions Update documentation Jun 23, 2022
@yuetloo yuetloo changed the title Update documentation Update documentation and replace rinkeby with goerli Jun 23, 2022
@@ -9,7 +9,7 @@ BRIGHTID_CONTEXT=clr.fund
BRIGHTID_VERIFIER_ADDR=0xb1d71F62bEe34E9Fc349234C201090c33BCdF6DB
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamstallard , do you know what the BRIGHTID_VERIFIER_ADDR is on georli?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke with Adam, he said that the address on Goerli will be the same address used for the other networks.

We will need to set up new BrightID contexts though.
We should essentially set up a separate clrfund context for each network that we (or others) might use. But this is out of scope for this PR and can be tracked elsewhere.

contracts/contracts/snarkVerifiers/README.md Show resolved Hide resolved
@yuetloo yuetloo marked this pull request as ready for review June 23, 2022 22:25
@yuetloo yuetloo requested a review from auryn-macmillan June 23, 2022 22:25
@auryn-macmillan auryn-macmillan merged commit c1168f7 into develop Jul 4, 2022
@auryn-macmillan auryn-macmillan deleted the update-doc branch July 4, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants