Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant qrpglesrc messages in the console #348

Closed
wants to merge 0 commits into from

Conversation

marcin-ogon
Copy link
Contributor

@marcin-ogon marcin-ogon commented Dec 11, 2024

Changes

Small console message improvement.
Additional comment validation added to check if copy is comment out
dcl-s cpyID char(25); //copy definition ID

This should fix #347

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in the README
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam
Copy link
Contributor

I am currently refactoring parser.js in another PR. This will come in behind it.

@worksofliam
Copy link
Contributor

@marcin-ogon I'd probably have another look at this PR now. Looks like some conflicts are up after the merge!

@marcin-ogon
Copy link
Contributor Author

@worksofliam Let me check the new version. If I find an issue, I will create a new PR. ;-)

@marcin-ogon
Copy link
Contributor Author

@worksofliam I did some more tests and noticed that my issue on the SourceOrbit side is due to a version difference. SourceOrbit is using vscode-rpgle@0.26.8. I was not able to recreate the issue on 0.27.0, so I assume that it’s already fixed. :-) If you have some time, please upgrade vscode-rpgle in SourceOrbit.

@worksofliam
Copy link
Contributor

@marcin-ogon

please upgrade vscode-rpgle in SourceOrbit

I will try and get to it next week. It's going to be a bit of work since I have changed a lot of the interfaces in vscode-rpgle this week for improved parsing and performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant messages in the console
2 participants