Removed code related to DOB and privateProfile.ttl #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekahung
added
enhancement
leekahung
requested review from
timbot1789,
xscottxbrownx,
andycwilliams and
Jared-Krajewski
timbot1789
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Resolves #525. It's mainly to remove DOB and relevant code from "Profile" in preparation to follow-up for PR #515 and have DOB in "Civic Profile" instead.
Additional Context (optional):
Given that there's dedicated page for "Profiles", we could move things that are more sensitive like "DOB" directly to there. Also relates to Issue #524 as we refine what should be in "Profile" vs. "Civic Profile".