Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Issue #646, switched order in npm start to run podserver first,… #652

Conversation

faddah
Copy link
Contributor

@faddah faddah commented Jun 6, 2024

This PR:

Resolves #646

1. Switched order in npm start of package so podserver is first, then npm run dev. ran it — all still works fine. All tests still run with no errors. Ready for merge.

Screenshots (if applicable):

Screenshot 2024-06-06 at 04 49 56 Screenshot 2024-06-06 at 04 51 39 Screenshot 2024-06-06 at 04 53 23

Additional Context (optional):

N/A

Future Steps/PRs Needed to Finish This Work (optional):

N/A

Issues needing discussion/feedback (optional):

1. None known.

Copy link
Contributor

@leekahung leekahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is fine. I can approve. Feel free to merge.

@faddah faddah merged commit 7b9378f into Development Jun 6, 2024
3 checks passed
@andycwilliams andycwilliams deleted the 646-switch-the-code-in-npm-start-in-package.json-to-run-podserver-first-then-the-pass-server branch June 8, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] - Switch the code in npm start in package.json to run Podserver first, THEN the PASS Server.
2 participants