Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring conditional directives. #378

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Refactoring conditional directives. #378

wants to merge 1 commit into from

Conversation

wmarquesr
Copy link

A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.

It might improve code understanding, maintainability and error-proneness.

@wmarquesr
Copy link
Author

You can review this PR ?

@ayurchen
Copy link
Member

ayurchen commented Jan 2, 2016

Sorry, man, no:

  1. this is not our code (but Fred Fish's), so we don't care
  2. readability is subjective, personally I don't find this patch an improvement
  3. "if it ain't broken, don't fix it"

Sorry, we have to be practical here - so many more serious bugs and issues.

@wmarquesr
Copy link
Author

Ok, but this patch improve the readability and understanding of the code, but as this code is of an external library i understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants