TODO-4256 : Set Galera library as submodule for MariaDB server #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: Before this change MariaDB server and Galera library were released on different times. Normally this ment that new Galera library version was pushed to repository and then you could fix possible test failures on MariaDB server regression testing. Mostly test failures was caused by new configuration variables or new visible status variables. Sometimes there was also other regressions possible and those might not be always visible on local testing. In Jenkings etc it is possible to test with some version of the galera library. This change makes it possible to have both galera library release and necessary MariaDB fixes on same commit and both are then tested on staging branch before they are pushed on main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: Before this change MariaDB server and Galera library were released on different times. Normally this ment that new Galera library version was pushed to repository and then you could fix possible test failures on MariaDB server regression testing. Mostly test failures was caused by new configuration variables or new visible status variables. Sometimes there was also other regressions possible and those might not be always visible on local testing. In Jenkings etc it is possible to test with some version of the galera library. This change makes it possible to have both galera library release and necessary
MariaDB fixes on same commit and both are then tested on staging branch before they are pushed on main
branch.