MDEV-34856 : Galera Cluster upgrade from 11.0 to 11.1 fails, eventual… #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly leads to crash This is regression from MDEV-18931 Rename Mariabackup's xtrabackup_* files to mariadb_backup_* commit b314f7b caused by fact that SST expects to find mariabackup_galera_info file but it does not exists if mariabackup backup is from older releases. Older releases have xtrabackup_galera_info file. If mariabackup_galera_info file does not exists we move old xtrabackup_galera_info to mariabackup_galera_info file. This will allow rolling upgrade from older releases to new releases using new name. Note that SST method rsync is not effected. Manually tested by starting 2-node cluster with 10.11 binary, issued shutdown to second node and starting second node with 11.4 binary.
sjaakola
requested changes
Sep 5, 2024
| [ -f "$MAGIC_FILE" ] && rm -f "$MAGIC_FILE" || : | ||
| [ -f "$DONOR_MAGIC_FILE" ] && rm -f "$DONOR_MAGIC_FILE" || : | ||
| [ -f "$MAGIC_FILE" ] && rm -rf "$MAGIC_FILE" || : | ||
| [ -f "$DONOR_MAGIC_FILE" ] && rm -rf "$DONOR_MAGIC_FILE" || : |
There was a problem hiding this comment.
why change to use rm -rf here? target file is a simple file not a directory to be removed recursively
| @@ -919,7 +928,7 @@ monitor_process() | |||
| done | |||
| } | |||
|
|
|||
| [ -f "$MAGIC_FILE" ] && rm -f "$MAGIC_FILE" | |||
| [ -f "$MAGIC_FILE" ] && rm -rf "$MAGIC_FILE" | |||
There was a problem hiding this comment.
also here, using -r flag is not obvious choice
| [ -f "$DATA/xtrabackup_binary" ] && rm -f "$DATA/xtrabackup_binary" | ||
| [ -f "$DATA/mariadb_backup_galera_info" ] && rm -f "$DATA/mariadb_backup_galera_info" | ||
| [ -f "$DATA/xtrabackup_binary" ] && rm -rf "$DATA/xtrabackup_binary" | ||
| [ -f "$DATA/mariadb_backup_galera_info" ] && rm -rf "$DATA/mariadb_backup_galera_info" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ly leads to crash
This is regression from MDEV-18931 Rename Mariabackup's xtrabackup_* files to mariadb_backup_* commit b314f7b caused by fact that SST expects to find mariabackup_galera_info file but it does not exists if mariabackup backup is from older releases. Older releases have xtrabackup_galera_info file.
If mariabackup_galera_info file does not exists we move old xtrabackup_galera_info to mariabackup_galera_info file. This will allow rolling upgrade from older releases to new releases using new name.
Note that SST method rsync is not effected.
Manually tested by starting 2-node cluster with 10.11 binary, issued shutdown to second node and starting second node with 11.4 binary.