Add application defined sequential consistency for certification #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temeo
force-pushed
the
seq_cb
branch
2 times, most recently
from
3b27be5 to
aa122bf
Compare
Client state methods before_prepare() and before_commit() accept a callback which is called by the provider after it can guarantee sequential consistency. This allows application threads which wish to maintain sequential consistency to enter before_prepare() and before_commit() calls concurrently without waiting the prior call to finish.
temeo
force-pushed
the
seq_cb
branch
4 times, most recently
from
946bb24 to
b063820
Compare
- Release commit time critical section in callback - Check the consistency inside commit order critical section Other: Add 2pc switch to dbsim
ayurchen
approved these changes
Dec 2, 2024
| @@ -495,7 +495,7 @@ int wsrep::transaction::before_commit() | |||
|
|
|||
| if (ret == 0 && state() == s_prepared) | |||
| { | |||
| ret = certify_commit(lock); | |||
| ret = certify_commit(lock, nullptr); | |||
There was a problem hiding this comment.
I see that the logic is not changed here, but
- how can we be sure that certify_commit() is not called here for the second time after before_prepare() above?
- why nullptr this time?
There was a problem hiding this comment.
The state is s_prepared, which is entered only during XA. XA commit fragment is always sent separately.
I'm not quite sure if it is correct to call the callback from XA commit fragment replication codepath, so passing nullptr keeps the old behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client state methods before_prepare() and before_commit() accept
a callback which is called by the provider after it can guarantee
sequential consistency. This allows application threads which wish to
maintain sequential consistency to enter before_prepare() and
before_commit() calls concurrently without waiting the prior call
to finish.