Add support for custom provider implementation #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temeo
force-pushed
the
grp-11.5-merge
branch
3 times, most recently
from
2303146 to
a029cfd
Compare
- Add a set_provider_factory() method to server_state to allow injecting provider factory which will be called when the provider is loaded. Other related changes: - Implement to_string() helper method for id class. - Fix id ostream operator human readable id printing. - Pass victim client_service as an argument to provider::bf_abort() to allow passing victim context to custom provider. - Implement prev() helper method for seqno class. - Make server_state recover_streaming_appliers_if_not_recovered() public. In some recovery scenarios the method must be called outside of server_state internal code paths. - Add storage_service requires_globals() method. The storage service implementation may override this to return false if changing to storage service context does not require store/reset globals. - Change view final() to also require that the view status is not primary for the view to be final. Also change the method name to is_final() to avoid confusion with C++ final identifier. - Fixes to server state handling in disconnecting and disconnected states. - Keep TOI meta data over whole TOI critical section. Co-authored-by: Denis Protivensky <denis.protivensky@galeracluster.com>
An id is considered an alphanumeric string if it contains a non-empty sequence of alphanumeric characters followed by one or more null characters. Fixed unit tests accordingly.
|
|
||
| auto ret = (provider().leave_toi(id_, toi_meta_, err) == provider::success ? 0 : 1); |
There was a problem hiding this comment.
Why are these lines swapped? Maybe you could add a comment to clarify?
There was a problem hiding this comment.
It was " Keep TOI meta data over whole TOI critical section." which didn't make it into PR description. Now updated.
leave_toi_common() resets toi_meta_, which is now passed to leave_toi().
denis-protivensky
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
injecting provider factory which will be called when the
provider is loaded.
Other related changes:
to allow passing victim context to custom provider.
public. In some recovery scenarios the method must be called outside
of server_state internal code paths.
implementation may override this to return false if changing to
storage service context does not require store/reset globals.
primary for the view to be final. Also change the method name to
is_final() to avoid confusion with C++ final identifier.
states.