MDEV-26851 : Add interface to monitor connections in Galera #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janlindstrom
force-pushed
the
connection_monitor_service
branch
from
9f5c99e to
e7f1ad3
Compare
temeo
requested changes
Jan 28, 2025
| @@ -0,0 +1,69 @@ | |||
| /* | |||
| * Copyright (C) 2024-2026 Codership Oy <info@codership.com> | |||
|
|
||
| #include "compiler.hpp" | ||
| #include "wsrep/buffer.hpp" | ||
| #include "v26/wsrep_connection_monitor_service.h" |
There was a problem hiding this comment.
Wsrep-API headers should not be exposed in wsrep-lib public headers. If you need this header for wsrep_connection_key_t type, I guess doing a matching typedef in this header would suffice.
janlindstrom
force-pushed
the
connection_monitor_service
branch
from
e7f1ad3 to
e15035c
Compare
temeo
reviewed
Jan 29, 2025
| namespace wsrep | ||
| { | ||
| /* Type tag for connection key. */ | ||
| typedef const void* wsrep_connection_key_t; |
There was a problem hiding this comment.
I think this should be in global namespace to match the wsrep-API definition.
janlindstrom
force-pushed
the
connection_monitor_service
branch
from
e15035c to
dbc8773
Compare
temeo
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.