feat(notifier): new notification pattern #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added redis helper class and some methods for digest and threshold storing - added env.sample for redis connections - added dependencies related to redis
- add notifier method to get threshold from redis or from db - add notifier method to check if event is critical - updated lock
- get rid of the buffer - move types to types directory - improve old comments
neSpecc
reviewed
Dec 18, 2024
slaveeks
approved these changes
Dec 21, 2024
e11sy
changed the title
neSpecc
reviewed
Dec 25, 2024
neSpecc
reviewed
Dec 25, 2024
neSpecc
reviewed
Dec 25, 2024
neSpecc
reviewed
Dec 25, 2024
e11sy
changed the title
This was referenced Jan 8, 2025
* update lock file * added tests for worker and redisHelper * typo * imp(notifier): improved testcase of the redis helper * fix(notifier-tests): afterall quit from redis * test(notifier-validator): remove check what to receive validation * feat(notifier-types): what to reveive All changed to SeenMore * test(notifier): restore RedisHelper original implementation before each test Added new testcases - should send event to channels at most once in one threshold period for one fitted rule, no matter how much events have passed - should compute event count for period for each fitted rule * revert: remove check what to receive validator * test(notifier): add testcase for new events * feat(notifier): add check for new events * lint fix * fix tests * test(notifier-worker): improve readability * test(notifier-worker): improve testcase * test(notifier-worker): improve testacase description * test(notifier-worker): improve testcase readability * test(notifier-worker): improve test description * but(): all bugs fixed * feat(): all features added * chore(): restore all bugs * bug(notifier): fix bug with channel enabled validation * update yarn.lock * fix tests * imp(notifier): updater redis structure key format * Update extensions.ts * improve docs * remove empty lines * fix(notifier): fix notifier redisHelper tests * fix(notifer): notifier redisHelpers tests fix * fix(notifier): fix notifier redisHelper test --------- Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
neSpecc
approved these changes
Feb 2, 2025
neSpecc
added a commit
that referenced
this pull request
Feb 3, 2025
* chore(logs): add logs and try catch blocks (#347) * Update redisHelper.ts * Update runner.ts * try-catch and logs to runner and redisHelper * Update runner.ts * fix: not increment affected users if user is not provided (#344) * feat(notifier): new notification pattern (#326) * add redis helper for notifier worker - added redis helper class and some methods for digest and threshold storing - added env.sample for redis connections - added dependencies related to redis * add notifier methods for threshold evaluation - add notifier method to get threshold from redis or from db - add notifier method to check if event is critical - updated lock * clean up in notifier * get rid of the buffer - get rid of the buffer - move types to types directory - improve old comments * fix lint issues * refactor notifier and tests * refactor notifier and tests * lint fix and remove redundant * remove unneeded database connection * improve naming and lua logic * implement redis testcontainer * refactor notifier tests with testcontainer * lint fix * typo fix * update lock file * fix lua script and naming * move Date.now() to variables * fix(notifier): fix notifier tests * fix(sender): fix sender type references * imp(notifier): improve redis structure key * imp(comments): improve docs * test(notifier): create tests for notifier and its redis helper (#338) * update lock file * added tests for worker and redisHelper * typo * imp(notifier): improved testcase of the redis helper * fix(notifier-tests): afterall quit from redis * test(notifier-validator): remove check what to receive validation * feat(notifier-types): what to reveive All changed to SeenMore * test(notifier): restore RedisHelper original implementation before each test Added new testcases - should send event to channels at most once in one threshold period for one fitted rule, no matter how much events have passed - should compute event count for period for each fitted rule * revert: remove check what to receive validator * test(notifier): add testcase for new events * feat(notifier): add check for new events * lint fix * fix tests * test(notifier-worker): improve readability * test(notifier-worker): improve testcase * test(notifier-worker): improve testacase description * test(notifier-worker): improve testcase readability * test(notifier-worker): improve test description * but(): all bugs fixed * feat(): all features added * chore(): restore all bugs * bug(notifier): fix bug with channel enabled validation * update yarn.lock * fix tests * imp(notifier): updater redis structure key format * Update extensions.ts * improve docs * remove empty lines * fix(notifier): fix notifier redisHelper tests * fix(notifer): notifier redisHelpers tests fix * fix(notifier): fix notifier redisHelper test --------- Co-authored-by: Peter Savchenko <specc.dev@gmail.com> --------- Co-authored-by: Peter Savchenko <specc.dev@gmail.com> --------- Co-authored-by: Peter <specc.dev@gmail.com> Co-authored-by: Vyacheslav Chernyshev <81693471+slaveeks@users.noreply.github.com> Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a part of the new notification system
check full design of this feature in figma file
What is new
Now on worker side we will have
criticalandnoncriticalevents (users would not know about terminology)Event rule would be formed as:
threshold, same aseventThresholdPeriodwould be determined in garage by user in rule confugurationWhat is notifications
threshold?Notifications
thresholdis a new term.thresholdrepetitions ineventTresholdPeriod, than event is critical and should be sent imidiatelyImplemented
redisHelperclass for storing of the digest and project thresholdsrulesremains)redis-mocklib