test(notifier): create tests for notifier and its redis helper #338

e11sy · 2024-12-25T19:23:17Z

Testcases

`RedisHelper`

should connect to redis client
should close redis client
should not throw error on close if client is already closed
should return event count
should reset counter and timestamp if threshold period is expired

`Notifier`

should send task if event threshold reached
should not send task if event count is more than event threshold
should not send task if event count is less than event threshold
should not check for event count and should not send event to sender if rule is disabled
should not check for event count and should not send event to sender if rule validation did not pass
should send event to all channels that are enabled in rule

workers/notifier/tests/worker.test.ts

…ch test Added new testcases - should send event to channels at most once in one threshold period for one fitted rule, no matter how much events have passed - should compute event count for period for each fitted rule

workers/notifier/tests/worker.test.ts

…x-team/hawk.workers into notifier-tests-improvements

* add redis helper for notifier worker - added redis helper class and some methods for digest and threshold storing - added env.sample for redis connections - added dependencies related to redis * add notifier methods for threshold evaluation - add notifier method to get threshold from redis or from db - add notifier method to check if event is critical - updated lock * clean up in notifier * get rid of the buffer - get rid of the buffer - move types to types directory - improve old comments * fix lint issues * refactor notifier and tests * refactor notifier and tests * lint fix and remove redundant * remove unneeded database connection * improve naming and lua logic * implement redis testcontainer * refactor notifier tests with testcontainer * lint fix * typo fix * update lock file * fix lua script and naming * move Date.now() to variables * fix(notifier): fix notifier tests * fix(sender): fix sender type references * imp(notifier): improve redis structure key * imp(comments): improve docs * test(notifier): create tests for notifier and its redis helper (#338) * update lock file * added tests for worker and redisHelper * typo * imp(notifier): improved testcase of the redis helper * fix(notifier-tests): afterall quit from redis * test(notifier-validator): remove check what to receive validation * feat(notifier-types): what to reveive All changed to SeenMore * test(notifier): restore RedisHelper original implementation before each test Added new testcases - should send event to channels at most once in one threshold period for one fitted rule, no matter how much events have passed - should compute event count for period for each fitted rule * revert: remove check what to receive validator * test(notifier): add testcase for new events * feat(notifier): add check for new events * lint fix * fix tests * test(notifier-worker): improve readability * test(notifier-worker): improve testcase * test(notifier-worker): improve testacase description * test(notifier-worker): improve testcase readability * test(notifier-worker): improve test description * but(): all bugs fixed * feat(): all features added * chore(): restore all bugs * bug(notifier): fix bug with channel enabled validation * update yarn.lock * fix tests * imp(notifier): updater redis structure key format * Update extensions.ts * improve docs * remove empty lines * fix(notifier): fix notifier redisHelper tests * fix(notifer): notifier redisHelpers tests fix * fix(notifier): fix notifier redisHelper test --------- Co-authored-by: Peter Savchenko <specc.dev@gmail.com> --------- Co-authored-by: Peter Savchenko <specc.dev@gmail.com>

* chore(logs): add logs and try catch blocks (#347) * Update redisHelper.ts * Update runner.ts * try-catch and logs to runner and redisHelper * Update runner.ts * fix: not increment affected users if user is not provided (#344) * feat(notifier): new notification pattern (#326) * add redis helper for notifier worker - added redis helper class and some methods for digest and threshold storing - added env.sample for redis connections - added dependencies related to redis * add notifier methods for threshold evaluation - add notifier method to get threshold from redis or from db - add notifier method to check if event is critical - updated lock * clean up in notifier * get rid of the buffer - get rid of the buffer - move types to types directory - improve old comments * fix lint issues * refactor notifier and tests * refactor notifier and tests * lint fix and remove redundant * remove unneeded database connection * improve naming and lua logic * implement redis testcontainer * refactor notifier tests with testcontainer * lint fix * typo fix * update lock file * fix lua script and naming * move Date.now() to variables * fix(notifier): fix notifier tests * fix(sender): fix sender type references * imp(notifier): improve redis structure key * imp(comments): improve docs * test(notifier): create tests for notifier and its redis helper (#338) * update lock file * added tests for worker and redisHelper * typo * imp(notifier): improved testcase of the redis helper * fix(notifier-tests): afterall quit from redis * test(notifier-validator): remove check what to receive validation * feat(notifier-types): what to reveive All changed to SeenMore * test(notifier): restore RedisHelper original implementation before each test Added new testcases - should send event to channels at most once in one threshold period for one fitted rule, no matter how much events have passed - should compute event count for period for each fitted rule * revert: remove check what to receive validator * test(notifier): add testcase for new events * feat(notifier): add check for new events * lint fix * fix tests * test(notifier-worker): improve readability * test(notifier-worker): improve testcase * test(notifier-worker): improve testacase description * test(notifier-worker): improve testcase readability * test(notifier-worker): improve test description * but(): all bugs fixed * feat(): all features added * chore(): restore all bugs * bug(notifier): fix bug with channel enabled validation * update yarn.lock * fix tests * imp(notifier): updater redis structure key format * Update extensions.ts * improve docs * remove empty lines * fix(notifier): fix notifier redisHelper tests * fix(notifer): notifier redisHelpers tests fix * fix(notifier): fix notifier redisHelper test --------- Co-authored-by: Peter Savchenko <specc.dev@gmail.com> --------- Co-authored-by: Peter Savchenko <specc.dev@gmail.com> --------- Co-authored-by: Peter <specc.dev@gmail.com> Co-authored-by: Vyacheslav Chernyshev <81693471+slaveeks@users.noreply.github.com> Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>

e11sy added 3 commits December 25, 2024 20:43

update lock file

0a6f528

added tests for worker and redisHelper

2a3810c

typo

40d6a58

neSpecc reviewed Dec 25, 2024

View reviewed changes

workers/notifier/tests/worker.test.ts Outdated Show resolved Hide resolved

workers/notifier/tests/worker.test.ts Outdated Show resolved Hide resolved

neSpecc reviewed Dec 25, 2024

View reviewed changes

workers/notifier/tests/worker.test.ts Outdated Show resolved Hide resolved

e11sy added 13 commits January 3, 2025 19:06

imp(notifier): improved testcase of the redis helper

2621576

fix(notifier-tests): afterall quit from redis

6287262

test(notifier-validator): remove check what to receive validation

60351bd

feat(notifier-types): what to reveive All changed to SeenMore

e757ca3

revert: remove check what to receive validator

63a6df4

test(notifier): add testcase for new events

7d789d2

feat(notifier): add check for new events

7bc852e

lint fix

bbafa56

fix tests

0148a15

test(notifier-worker): improve readability

302adcf

test(notifier-worker): improve testcase

c0bdc94

test(notifier-worker): improve testacase description

eafbf81

neSpecc reviewed Jan 3, 2025

View reviewed changes

workers/notifier/tests/worker.test.ts Show resolved Hide resolved

e11sy added 2 commits January 4, 2025 00:45

test(notifier-worker): improve testcase readability

bb0514e

test(notifier-worker): improve test description

f28c355

e11sy changed the title ~~chore(notifier-tests): create tests for notifier and its redis helper~~ test(notifier): create tests for notifier and its redis helper Jan 3, 2025

neSpecc approved these changes Jan 3, 2025

View reviewed changes

e11sy and others added 7 commits January 25, 2025 22:28

but(): all bugs fixed

cde50c4

feat(): all features added

f77e2ef

chore(): restore all bugs

50f36ba

bug(notifier): fix bug with channel enabled validation

5b2979b

Merge branch 'notifier-refactoring' into notifier-tests-improvements

5b142f3

update yarn.lock

2b2bc6c

fix tests

0335b6d

e11sy and others added 10 commits February 2, 2025 23:48

imp(notifier): updater redis structure key format

693e211

Update extensions.ts

8d9083b

improve docs

c5266b7

Merge branch 'notifier-tests-improvements' of https://github.com/code…

1d7e0b2

…x-team/hawk.workers into notifier-tests-improvements

update from notifier-refactoring

9b6cfa6

remove empty lines

c81f85f

Merge branch 'notifier-refactoring' into notifier-tests-improvements

70507ec

fix(notifier): fix notifier redisHelper tests

0cb1d65

fix(notifer): notifier redisHelpers tests fix

13cbd8b

fix(notifier): fix notifier redisHelper test

8671672

e11sy merged commit 0ef30b2 into notifier-refactoring Feb 2, 2025
2 of 3 checks passed

e11sy deleted the notifier-tests-improvements branch February 2, 2025 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(notifier): create tests for notifier and its redis helper #338

test(notifier): create tests for notifier and its redis helper #338

e11sy commented Dec 25, 2024

test(notifier): create tests for notifier and its redis helper #338

test(notifier): create tests for notifier and its redis helper #338

Conversation

e11sy commented Dec 25, 2024

Testcases

RedisHelper

Notifier

`RedisHelper`

`Notifier`