refactor utils #141
Closed
refactor utils #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this diff is large due to the removal of a duplicate select_range function that seems to be a copy/paste error. This adds a parameter and simplifies the logic for normalizing the v_table values
aarondill
force-pushed
the
refactor-utils
branch
from
2ac28da to
dd47702
Compare
|
Thanks for the contribution @aarondill, this is a big change which needs to be heavily tested.. might worth to split to multiple PRS? |
This more clearly describes what it returns. script_path is replaced with script_dir which returns a value based on the currently running file note: module_dir relies on utils.lua's location, and will break if the file is moved
use { current_position() } for the old behavior.
This is unused in the code base. should it be removed?
…tr=='' This special case seems to be unused in the codebase and is very unintuitive.
Slight code changes, no behavior changes.
table.pack can't be used here because neovim functions will error if a `n` key is present.
aarondill
force-pushed
the
refactor-utils
branch
from
dd47702 to
1c329f6
Compare
|
@amirbilu sorry for never responding. I can split this up (and probably should). I can see this being split into three PRs:
the first two would be fairly small, but the third would still have a large (green) diff, as non of the functions currently have types, and would now all need comments describing the types. |
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
tabnine.utilsmodule to add types and fix some minor issues.The list of commits is below. Each commit should include a description of the change (or be self-evident).