-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CRUD + Charge for tokenised credit cards #22
base: master
Are you sure you want to change the base?
Conversation
Hi @Zensavona, this looks good. I have started in a different branch to provide tokenization for credit cards, but never end up finishing it. |
@speeddragon great - I'll just get those tests to pass on travis (works locally - I guess it's not using the saved VCR cassettes for some reason?) |
P.S. that's actually an entirely different service - TMS !== On-Demand Billing |
You're right. Looking better into the PR, maybe it could be better to move these methods into a new module, like |
@speeddragon should we take a look into the PR or do you prefer to handle it? |
This PR needs a refactor since the Client module is getting huge, as mentioned in my last comment. |
@Zensavona can you evaluate the refactor suggestion made by @speeddragon and implement it? |
@rageofflames / @speeddragon since the Client module is getting huge, is it a problem from your guys' perspective to break the existing API and split it up? That's the reason I left it this way. Just let me know about that and I'll get to it when I have a spare couple hours. |
We definitely should break it. If I have some time I will try to improve it also. |
make subscriptionID optional in paySubscriptionUpdateReply
Basic quick + dirty support for creating, reading, updating, deleting and charging tokenised credit cards
Tests included + updated.
Note: I had to break your API for
bill_to
slightly to add extra fields because you didn't includepostcode
orstate
which are required here.