Add first class Javascript/Typescript support to the Mill build tool #4398
Conversation
- htmlReports for coverage
|
The docs for |
|
Is there a reason |
yes, mill generates by default those files... but you can opt to use yours. I will update the testing docs. |
will clean out the auto-format docs |
- allow use of custom test suite configurations
| @@ -1,23 +0,0 @@ | |||
| import {pathsToModuleNameMapper} from 'ts-jest'; | |||
There was a problem hiding this comment.
Is there a reason these files were deleted?
| } | ||
| } | ||
|
|
||
| > mill foo.checkFormatAll # run linter - since both eslint and prettier configurations are present, mill will opt to use eslint. |
There was a problem hiding this comment.
Let's move the default checkFormatAll command to an ExternalModule, similar to ScalafmtModule/PalantirFormatModule/KtlintModule. That will help standardize the user experience across Mill language toolchains
| Checking formatting... | ||
| [warn] foo/src/foo.ts | ||
| [warn] Code style issues found. Run foo.reformatAll to fix. | ||
| */ |
There was a problem hiding this comment.
This example should focus on non-autoformat-able lint errors, as the 2-autoformatting/ section already covers those. This section should also demonstrate that fixing the error (e.g. using sed) makes the lint errors go away.
| @@ -1,31 +0,0 @@ | |||
| import {pathsToModuleNameMapper} from 'ts-jest'; | |||
| } | ||
|
|
||
| // web browser - serve coverage report | ||
| def htmlReport: T[Unit] = Task { |
There was a problem hiding this comment.
Is there a way to just return a HTML file on disk rather than serving it in a web browser?
| os.symlink(Task.workspace / "out/.nycrc", compile()._1.path / ".nycrc") | ||
| } | ||
|
|
||
| def nycrcBuilder: Task[Path] = Task.Anon { |
There was a problem hiding this comment.
This task is very weird. It seems like it should be a T[PathRef] returning the config file it writes
There was a problem hiding this comment.
Also what's nycrc? Maybe use a longer name or add a comment?
|
|
||
| // <rootDir> = '/out'; allow coverage resolve distributed source files. | ||
| // & define coverage files relative to <rootDir>. | ||
| private[TestModule] def link: Task[Unit] = Task.Anon { |
There was a problem hiding this comment.
This name is far too short given how niche the task is. Maybe call it coverageSetupSymlinks or something?
|
|
||
| def getConfigFile: T[String] = | ||
| Task { (compile()._1.path / "jest.config.ts").toString } | ||
| def conf: Task[Path] = Task.Anon { |
There was a problem hiding this comment.
This looks like it should be a T[PathRef]
| @@ -96,42 +199,116 @@ object TestModule { | |||
| runTest() | |||
| } | |||
|
|
|||
| // with coverage | |||
| def coverageConf: Task[Path] = Task.Anon { | |||
| File...| % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s... | ||
| ---------------|---------|----------|---------|---------|------------------- | ||
| ...All files...|...100 |...100 |...100 |...100 |... | ||
| ...calculator.ts...|...100 |...100 |...100 |...100 |... |
There was a problem hiding this comment.
At least one of the code coverage examples should have <100% coverage so we can check that that behaves as expected
This pr implements the examples for jslib/dependencies.
#3927
Checklist:
Key changes: