Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selective testing of native example tests by adding jvm version override #4410

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Fix selective testing of native example tests by adding jvm version override #4410

merged 4 commits into from
Jan 28, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jan 27, 2025 •
edited
Loading

Minimized in #4357, it appears the difference in behavior comes from different JVM versions being used during selective.prepare and selective.{resolve,run} phases

@lihaoyi
Copy link
Member Author

lihaoyi commented Jan 28, 2025

Seems to have worked, as the .native targets are no longer being spuriously selected by selective.resolve https://github.com/com-lihaoyi/mill/actions/runs/13001357943/job/36260711097

@lihaoyi lihaoyi merged commit 5151dc2 into com-lihaoyi:main Jan 28, 2025
31 checks passed
@lihaoyi lihaoyi mentioned this pull request Jan 28, 2025
Closed
@lefou lefou added this to the 0.12.6 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.6
Development

Successfully merging this pull request may close these issues.
2 participants
@lihaoyi @lefou